Repository navigation
Update EIP-2780: variable rename + 8007 clean-ups - #12052
Merged
Merged
Conversation
github-actions
Bot
added
c-update
Collaborator
|
✅ All reviewers have approved. |
eth-bot
changed the title
2 tasks done
misilva73
marked this pull request as ready for review
July 31, 2026 08:25
Contributor
Author
|
@eth-bot rerun |
eth-bot
enabled auto-merge (squash)
July 31, 2026 08:26
eth-bot
previously approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
auto-merge was automatically disabled
July 31, 2026 08:38
Head branch was pushed to by a user without write access
eth-bot
enabled auto-merge (squash)
July 31, 2026 08:39
eth-bot
previously approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
auto-merge was automatically disabled
July 31, 2026 09:19
Head branch was pushed to by a user without write access
eth-bot
enabled auto-merge (squash)
July 31, 2026 09:20
eth-bot
previously approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
auto-merge was automatically disabled
July 31, 2026 12:54
Head branch was pushed to by a user without write access
eth-bot
enabled auto-merge (squash)
July 31, 2026 12:55
eth-bot
approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
|
The commit 3641bd3 (as a parent of 1b30651) contains errors. |
Contributor
Author
|
@eth-bot rerun |
eth-bot
approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
…ASE_COST Renames the per-authorization base cost constant defined in EIP-8037 and referenced by EIP-2780 and EIP-8007, aligning it with the execution-gas / state-gas dimension naming already used in EIP-8037. Also updates the accompanying prose in EIP-2780 and EIP-8007, which still described the dimension as "regular gas", to say "execution gas".
- Note the EIP-7778 x EIP-8037 interaction: the refund exclusion applies to the execution-gas dimension only, since state-gas refills reverse charges for state that was never durably created - Add transaction-level rows for zero-value and contract-creation intrinsic costs, per-EIP-7702 authorization costs, and the EIP-8038 access list entry increases - Replace the stale TX_VALUE_COST/TRANSFER_LOG_COST split with EIP-2780's single TX_VALUE_COST (6,000) - Correct the access list data cost to EIP-7981's flat 64 gas per byte surcharge, charged outside the calldata floor max - Note EIP-8037's effects on EIP-7825's TX_MAX_GAS_LIMIT and on the system-call gas limit
Fixes the markdown-link-first eipw error: the first occurrence of a proposal reference must be a link.
eipw's markdown-spell rejects tokens that glue digits to letters, so `150M`, `2x`, `24kB`, `21k` and `63/64ths` all failed. Rather than add every magnitude to the shared dictionary, write them in forms the lint already accepts: - gas limits as inline code: `150M`, `30M`, `60M`, `100M`..`300M`, `5M` - multipliers with the multiplication sign: 2x -> 2×, ~7x -> ~7× - 24kB -> 24 kB, 21k -> 21,000, 100k -> 100,000 - 63/64ths -> 63/64, matching the existing wording in the same section No normative content changes.
eipw's markdown-spell skips inline code spans but checks prose, emphasis and link text. Most of the flagged words are either identifiers that should have been backticked anyway or have an accepted alternative in the dictionary, so fix them in place instead of extending the shared dictionary: - backtick identifiers: CPSB (eip-8007 tables, eip-8037 heading), Create2Deployer, ImmutableCreate2Factory, CreateX - BAL -> block-level access list (spelled out in the same sentence) - runtimes -> run times; NA -> N/A; presigned -> pre-signed; prefunded -> pre-funded; deployers -> deployer contracts - equilibrates -> converges; unpriced -> not priced; parallelizable -> an operation that can be parallelized - misprices/mispricing -> prices incorrectly / pricing mismatch, and rename the eip-8037 heading with its cross-reference anchor - drop the NNLS acronym, used only once - EIP-7923 row: paraphrase "Linearize Memory Costing" as "Make memory costing linear" Only Glamsterdam, Perfnet, GiB and MiB still need dictionary entries. No normative content changes.
auto-merge was automatically disabled
July 31, 2026 15:27
Head branch was pushed to by a user without write access
misilva73
force-pushed
the
update-repricing-eips
branch
from
July 31, 2026 15:27
3641bd3 to
bb1c38b
Compare
eth-bot
enabled auto-merge (squash)
July 31, 2026 15:28
eth-bot
previously approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
EIP-8037 is in Review, and ERC-2470 is Stagnant, so eipw's markdown-link-status rejects the link; naming the proposal without a link instead trips markdown-link-first. Referring to the contract (SingletonFactory) satisfies both and matches the sibling entries in the list.
auto-merge was automatically disabled
July 31, 2026 15:34
Head branch was pushed to by a user without write access
eth-bot
enabled auto-merge (squash)
July 31, 2026 15:35
eth-bot
approved these changes
Jul 31, 2026
eth-bot
left a comment
eth-bot
left a comment
Collaborator
There was a problem hiding this comment.
All Reviewers Have Approved; Performing Automatic Merge...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.