feat(kona-genesis): add rollup_config_override feature for custom max sequencer drift#19994
Merged
feat(kona-genesis): add rollup_config_override feature for custom max sequencer drift#19994
Conversation
… sequencer drift Add a `rollup_config_override` feature to kona-genesis that overrides the Fjord max sequencer drift to 2892s for chains building only on finalized L1 blocks, where L1 finality delays can exceed the standard 1800s limit. This replaces #18859 until the proper solution is in place, see #18859 (comment) Since this is only a temporary solution, I've chosen the small and primitive solution over a more generic approach.
…lupConfig field Replace the hardcoded constant override with a runtime-configurable fjord_max_sequencer_drift field on RollupConfig, gated behind the rollup_config_override feature flag. This allows chains that build on finalized L1 blocks to set a custom max sequencer drift via config rather than a compile-time constant.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19994 +/- ##
===========================================
+ Coverage 11.7% 63.2% +51.5%
===========================================
Files 677 194 -483
Lines 71141 10878 -60263
===========================================
- Hits 8328 6882 -1446
+ Misses 62669 3852 -58817
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
… imports The rust/kona registry crate was missing the rollup_config_override feature, causing CI failures when building with --all-features. The FJORD_MAX_SEQUENCER_DRIFT imports also need to be conditional to avoid unused import warnings when the feature is disabled.
theochap
force-pushed
the
theo/kona-rollup-config-override
branch
from
2d04899 to
1150d9b
Compare
nonsense
approved these changes
Apr 9, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
InoMurko
pushed a commit
to ConstellationCrypto/optimism
that referenced
this pull request
Apr 12, 2026
… sequencer drift (ethereum-optimism#19994) * feat(kona-genesis): add rollup_config_override feature for custom max sequencer drift Add a `rollup_config_override` feature to kona-genesis that overrides the Fjord max sequencer drift to 2892s for chains building only on finalized L1 blocks, where L1 finality delays can exceed the standard 1800s limit. This replaces ethereum-optimism#18859 until the proper solution is in place, see ethereum-optimism#18859 (comment) Since this is only a temporary solution, I've chosen the small and primitive solution over a more generic approach. * feat(kona-genesis): make fjord_max_sequencer_drift a configurable RollupConfig field Replace the hardcoded constant override with a runtime-configurable fjord_max_sequencer_drift field on RollupConfig, gated behind the rollup_config_override feature flag. This allows chains that build on finalized L1 blocks to set a custom max sequencer drift via config rather than a compile-time constant. * Format with correct toolchain version * fix(kona-registry): add missing fjord_max_sequencer_drift to test config initializers * fix(kona-registry): propagate rollup_config_override feature and gate imports The rust/kona registry crate was missing the rollup_config_override feature, causing CI failures when building with --all-features. The FJORD_MAX_SEQUENCER_DRIFT imports also need to be conditional to avoid unused import warnings when the feature is disabled. --------- Co-authored-by: Karl Bartel <karl.bartel@clabs.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rollup_config_overrideCargo feature tokona-genesis(and propagated throughkona-registry) that exposes a configurablefjord_max_sequencer_driftfield onRollupConfig.FJORD_MAX_SEQUENCER_DRIFTconstant. When on, each chain can override the value (useful for chains that build only on finalized L1 blocks, where L1 finality delays can exceed the standard drift).develop, which hadinterop_message_expiry_windowremoved since that PR was authored. Dangling references to the removed field/constant are cleaned up so the workspace builds.Supersedes #19131.
Test plan
just b(workspace builds without the feature)cargo check -p kona-genesis --features rollup_config_override(feature-gated path compiles)cargo nextest run -p kona-genesis --features rollup_config_override(newrollup_config_override_testspass)🤖 Generated with Claude Code