Skip to content

chore(op-devstack): fix rust binary error message and add debug build targets#19988

Merged
sebastianst merged 2 commits intodevelopfrom
seb/chore/rust-binary-fixes
Apr 8, 2026
Merged

chore(op-devstack): fix rust binary error message and add debug build targets#19988
sebastianst merged 2 commits intodevelopfrom
seb/chore/rust-binary-fixes

Conversation

@sebastianst
Copy link
Copy Markdown
Member

Summary

  • Fix misleading error message in rust_binary.go that referenced non-existent just build-rust-debug target — now dynamically suggests the correct target per binary (e.g. cd rust && just build-op-reth-debug)
  • Add target/debug/ to the binary search path in resolveBuiltRustBinaryPath (release still takes priority)
  • Add build-op-reth-debug and build-kona-node-debug just targets for faster local E2E test iteration
  • Rename build-node to build-kona-node for consistency, keep build-node as alias

Test plan

  • cd rust && just --list shows new targets and alias
  • cd rust && just build-op-reth-debug builds successfully
  • go vet ./op-devstack/sysgo/... passes
  • E2E tests find debug binaries after just build-op-reth-debug

🤖 Generated with Claude Code

… target

- Fix error message in rust_binary.go to reference the correct just
  target (`cd rust && just build-<binary>`) instead of the non-existent
  `just build-rust-debug`
- Search debug/ in addition to release/ when resolving pre-built Rust
  binaries, with release taking priority
- Add `build-op-reth-debug` just target for faster local E2E test
  iteration (debug builds compile much faster than release)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sebastianst sebastianst requested a review from a team as a code owner April 8, 2026 20:16
Comment thread op-devstack/sysgo/rust_binary.go Outdated
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sebastianst sebastianst enabled auto-merge April 8, 2026 20:34
@sebastianst sebastianst added this pull request to the merge queue Apr 8, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.5%. Comparing base (63dce55) to head (3919172).
⚠️ Report is 3 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (63dce55) and HEAD (3919172). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (63dce55) HEAD (3919172)
cannon-go-tests-64 1 0
contracts-bedrock-tests 9 0
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19988      +/-   ##
===========================================
- Coverage     11.8%     0.5%   -11.4%     
===========================================
  Files          677      483     -194     
  Lines        71115    60263   -10852     
===========================================
- Hits          8440      320    -8120     
+ Misses       62531    59943    -2588     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests ?
unit 0.5% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 194 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into develop with commit 9d68e89 Apr 8, 2026
161 checks passed
@sebastianst sebastianst deleted the seb/chore/rust-binary-fixes branch April 8, 2026 21:17
InoMurko pushed a commit to ConstellationCrypto/optimism that referenced this pull request Apr 12, 2026
… targets (ethereum-optimism#19988)

* chore(op-devstack): fix rust binary error message and add debug build target

- Fix error message in rust_binary.go to reference the correct just
  target (`cd rust && just build-<binary>`) instead of the non-existent
  `just build-rust-debug`
- Search debug/ in addition to release/ when resolving pre-built Rust
  binaries, with release taking priority
- Add `build-op-reth-debug` just target for faster local E2E test
  iteration (debug builds compile much faster than release)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore(op-devstack): default JIT build to debug mode

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants