chore(op-devstack): fix rust binary error message and add debug build targets#19988
Merged
sebastianst merged 2 commits intodevelopfrom Apr 8, 2026
Merged
chore(op-devstack): fix rust binary error message and add debug build targets#19988sebastianst merged 2 commits intodevelopfrom
sebastianst merged 2 commits intodevelopfrom
Conversation
… target - Fix error message in rust_binary.go to reference the correct just target (`cd rust && just build-<binary>`) instead of the non-existent `just build-rust-debug` - Search debug/ in addition to release/ when resolving pre-built Rust binaries, with release taking priority - Add `build-op-reth-debug` just target for faster local E2E test iteration (debug builds compile much faster than release) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joshklop
approved these changes
Apr 8, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #19988 +/- ##
===========================================
- Coverage 11.8% 0.5% -11.4%
===========================================
Files 677 483 -194
Lines 71115 60263 -10852
===========================================
- Hits 8440 320 -8120
+ Misses 62531 59943 -2588
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
InoMurko
pushed a commit
to ConstellationCrypto/optimism
that referenced
this pull request
Apr 12, 2026
… targets (ethereum-optimism#19988) * chore(op-devstack): fix rust binary error message and add debug build target - Fix error message in rust_binary.go to reference the correct just target (`cd rust && just build-<binary>`) instead of the non-existent `just build-rust-debug` - Search debug/ in addition to release/ when resolving pre-built Rust binaries, with release taking priority - Add `build-op-reth-debug` just target for faster local E2E test iteration (debug builds compile much faster than release) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore(op-devstack): default JIT build to debug mode Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust_binary.gothat referenced non-existentjust build-rust-debugtarget — now dynamically suggests the correct target per binary (e.g.cd rust && just build-op-reth-debug)target/debug/to the binary search path inresolveBuiltRustBinaryPath(release still takes priority)build-op-reth-debugandbuild-kona-node-debugjust targets for faster local E2E test iterationbuild-nodetobuild-kona-nodefor consistency, keepbuild-nodeas aliasTest plan
cd rust && just --listshows new targets and aliascd rust && just build-op-reth-debugbuilds successfullygo vet ./op-devstack/sysgo/...passesjust build-op-reth-debug🤖 Generated with Claude Code