op-node/derive: drop bad channel decompression as NotEnoughData#19499
Merged
sebastianst merged 2 commits intodevelopfrom Mar 12, 2026
Merged
op-node/derive: drop bad channel decompression as NotEnoughData#19499sebastianst merged 2 commits intodevelopfrom
sebastianst merged 2 commits intodevelopfrom
Conversation
Fixes WriteChannel error classification in ChannelInReader.NextBatch: returns NotEnoughData (immediate continue, no backoff) instead of NewTemporaryError when channel data fails to decompress. Also downgrades the log.Error in WriteChannel to log.Warn since this is bad batcher data, not an infrastructure failure. Fixes #19492.
sebastianst
commented
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteChannelerror classification inChannelInReader.NextBatch: returnsNotEnoughData(immediate continue, no backoff) instead ofNewTemporaryErrorwhen channel data fails to decompresslog.ErrorinWriteChanneltolog.Warnsince this is bad batcher data, not an infrastructure failureThe channel is already consumed from the
ChannelBank/ChannelAssemblerbeforeWriteChannelis called, so a retry would not re-read the same channel. TheTemporaryErrorcaused one unnecessary backoff cycle and misleadingError-level logging.Closes #19492. Part of #19491.
🤖 Generated by Claude Code