Skip to content

[BREAKING] polledTimeout: new remaining() returns time units until (next) expiration - #6843

Closed
dok-net wants to merge 16 commits into
esp8266:masterfrom
dok-net:polledTimeout_remaining
Closed

[BREAKING] polledTimeout: new remaining() returns time units until (next) expiration#6843
dok-net wants to merge 16 commits into
esp8266:masterfrom
dok-net:polledTimeout_remaining

Conversation

@dok-net

@dok-net dok-net commented Nov 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

There are cases where the remaining time until the next expiration is needed.
remaining() returns that time value.
Also prevent the call to YieldPolicyT::execute() for expired timers, this looks like it generally just wastes time in needless delays.
It's a breaking change due to the removal of alwaysExpired id 0.

devyte
devyte requested changes Nov 27, 2019
View reviewed changes
Comment thread cores/esp8266/PolledTimeout.h Outdated
Comment thread cores/esp8266/PolledTimeout.h Outdated
d-a-v
d-a-v reviewed Nov 27, 2019
View reviewed changes
Comment thread cores/esp8266/PolledTimeout.h Outdated
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from a361dec to 776f2a1 Compare November 28, 2019 07:12
@dok-net dok-net changed the title polledTimeout: new expiresIn() complements bool() polledTimeout: new remaining() returns time units until (next) expiration Dec 1, 2019
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 996b469 to 47e82b1 Compare December 2, 2019 22:44
d-a-v
d-a-v reviewed Dec 4, 2019
View reviewed changes
Comment thread cores/esp8266/PolledTimeout.h Outdated
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 4e284dc to f2a78ac Compare December 4, 2019 12:05
@d-a-v
d-a-v requested review from d-a-v and devyte December 4, 2019 12:16
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from f2a78ac to f33b2e0 Compare December 11, 2019 13:44
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from f33b2e0 to a2166d8 Compare January 18, 2020 15:28
@dok-net
dok-net force-pushed the polledTimeout_remaining branch 2 times, most recently from 9f40cc1 to ab9d8f6 Compare February 5, 2020 06:33
@dok-net
dok-net force-pushed the polledTimeout_remaining branch 2 times, most recently from d636ed7 to 740670a Compare March 3, 2020 07:58
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 740670a to 6e02512 Compare April 9, 2020 22:08
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 6e02512 to df5c1e0 Compare May 2, 2020 00:59
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from df5c1e0 to a4e89b5 Compare June 15, 2020 19:42
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from a4e89b5 to 95eedb8 Compare July 16, 2020 10:51
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 95eedb8 to abed7f3 Compare October 22, 2020 15:56
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from abed7f3 to 9f539f9 Compare December 30, 2020 15:26
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 9f539f9 to 0e812a6 Compare January 28, 2021 20:37
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 0e812a6 to ea24874 Compare March 15, 2021 10:48
@dok-net dok-net mentioned this pull request Mar 15, 2021
Merged
7 tasks
@dok-net
dok-net force-pushed the polledTimeout_remaining branch 3 times, most recently from 098fd21 to 2c18f67 Compare March 16, 2021 07:11
@dok-net dok-net changed the title polledTimeout: new remaining() returns time units until (next) expiration [BREAKING] polledTimeout: new remaining() returns time units until (next) expiration Apr 5, 2021
@dok-net
dok-net force-pushed the polledTimeout_remaining branch 2 times, most recently from efe2ce5 to a4268a9 Compare April 5, 2021 11:23
dok-net added 15 commits April 5, 2021 17:32
@dok-net
Add function to retrieve the time remaining until the (next) timeout …
1f5b6a1 
…occurs.
@dok-net
Rename and reformat according to review.
21b6afa
@dok-net
Revert _current as member change.
dc3db41
@dok-net
Fix expiredOneShot to properly stay expired forever unless reset.
0743684
@dok-net
Fix "reverse notation return statement"
36241a9
@dok-net
Reset() was wrecked by resetting _timeout. Reverted.
7e429cc
@dok-net
Expired check ALWAYS executes yield policy BEFORE checking expiration…
543766f 
… - that's wasted time.

Expired keeps executing yield policy on already expired oneShot - that's counter intuitive and wasted time.
@dok-net
Reformat
2a6bbf5
@dok-net
Fix comment, remove redundant parentheses
ce6982b
@dok-net
expired() is not const qualified in PolledTmeout.
05272e5
@dok-net
expiredOneShot() qualifed as const, despite asymmetry with expired() …
ed920df 
…and expiredRetrigger().

_oneShotExpired qualified as mutable member.
This is done as intermediate fix for use in derived class ESP8266WiFiMesh ExpiringTimeTracker.
@dok-net
Remove alwaysExpired, it is identical to 0 and obfuscates the code.
e942bcc
@dok-net
Somewhat easier on the human reader.
8a9d25b
@dok-net
Avoid possible unnecessary time conversion.
1d68d42
@dok-net
Fix one-shot mode in resetToNeverExpires(). Add convenient stop() syn…
9430a39 
…onym for same function.
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 032f2d6 to 9430a39 Compare April 5, 2021 15:32
@dok-net
dok-net force-pushed the polledTimeout_remaining branch from 0ade799 to a0edd7d Compare April 5, 2021 20:12
@dok-net

dok-net commented Apr 7, 2021

Copy link
Copy Markdown
Contributor Author

Superseded by #7960.

@dok-net dok-net closed this Apr 7, 2021
@dok-net
dok-net deleted the polledTimeout_remaining branch April 7, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devyte devyte Awaiting requested review from devyte
@d-a-v d-a-v Awaiting requested review from d-a-v

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dok-net @d-a-v @devyte