Revert to nonos-sdk 2.2.1, new selection menu for generic board only - #5763
Merged
Conversation
This commit allows switching SDK firmware:
Some boards show erratic behavior (radio connection is quickly lost), with
an unknown cause, when using nonos-sdk-pre-v3 (shipped with release 2.5.0).
These boards work well with previous nonos-sdk-2.2.1 firmware.
Current firmware, which has brought long awaited fixes (WiFi sleep modes),
stays as default.
To switch:
./tools/boards.txt.py --sdk=NONOSDK221 --allgen
(default) ./tools/boards.txt.py --sdk=NONOSDK3V0 --allgen
BREAKING for external build systems:
new directories to add
lib: tools/sdk/lib/<version>/lib
include: tools/sdk/lib/<version>/include
Fix esp8266#5736
6 tasks
6 tasks
d-a-v
changed the title
devyte
approved these changes
Feb 19, 2019
devyte
left a comment
devyte
left a comment
Collaborator
There was a problem hiding this comment.
This PR hurts my heart, but I agree it's the best path forward for now. Better to assure stability and have a known bug for a specific use case, over random instability and having the bug fix.
I suggest having a master issue to cover the issues in sdk pre3, and link the issues with specific problems to that one. Also, that issue should document the impact of, and how to move between, each of the sdk versions.
|
Any chance of a 2.5.1 version with this fix included? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit allows switching SDK firmware:
nonos-sdk-pre-v3 shipped with release 2.5.0 has issues:
These boards work well with previous nonos-sdk-2.2.1 firmware (ESP8266WebServer hangs after updating to 2.5.0 #5736)
This PR restores sdk2.2.1 (as in core-2.4.2).
SDK-pre-3.0 - which has brought long awaited fixes (WiFi sleep modes) - is still available through a menu option available only with generic board.
BREAKING
-DNONOSDK221=1or-DNONOSDK3V0=1tools/sdk/lib/<version>/libPIO_FRAMEWORK_ARDUINO_ESPRESSIF_SDK3is needed for sdk-pre-v3.Fix #5736