feat(input_drivers): Update pointer_input to better handle screen rotation#553
Merged
feat(input_drivers): Update pointer_input to better handle screen rotation#553
pointer_input to better handle screen rotation#553Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pointer_input component to properly handle screen rotation by dynamically adjusting cursor boundary clamping based on the current display rotation. Instead of using fixed screen dimensions, the code now queries the display rotation at runtime and adjusts the clamp boundaries accordingly to ensure the cursor remains visible within screen bounds regardless of orientation.
Key Changes
- Replaced static screen size member variables with runtime display queries
- Added rotation-aware cursor boundary clamping logic with rotation-specific adjustments
- Removed initialization of screen size variables from the initialization method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
✅Static analysis result - no issues found! ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
input_driversso thatpointer_inputbetter handles pointer input on rotated displaysMotivation and Context
Ensures that if a pointer input is used on a non-square rotated display, such as could happen on the
t-deckand in thet-deck/examplethe pointer is able to reach all parts of the screen and doesn't go off the screen.How has this been tested?
Running as part of a forthcoming change to the
t-deck/example.Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):
Types of changes
Checklist:
Software
.github/workflows/build.ymlfile to add my new test to the automated cloud build github action.