Give a better error message for ESMF_Initialize after ESMF_Finalize#368
Merged
Conversation
The previous error message in this case was more cryptic: ESMF_LogWrite(): ESMF_Log not open -- cannot ESMF_LogWrite(). Log message = Object being used after deletion - Bad Object
Member
Author
|
@oehmke - I'd welcome a quick review whenever you get a chance |
Contributor
|
Team reviewed during core team meeting and approved this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous error message in this case was more cryptic:
The new error message is:
This case seems hard (or maybe impossible) to test in the unit testing framework, but I have tested it with the code here:
https://github.com/billsacks/esmfprojects-multiple_esmf_initializes