Repository navigation
fix(mcp): import cc-switch servers without sqlite3 - #14069
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
esengine
left a comment
There was a problem hiding this comment.
Reviewed: the bundled modernc driver is already a dependency, the read-only DSN keeps the old sqlite3 -readonly semantics, the schema probe and row read are equivalent to the old two commands, and the Windows drive-path DSN has its own test. I also ran the cc-switch tests on this head locally. Approving; merge after the checks are green.
|
The checks on this head fail for one reason, and it is ours to fix before merging: the nested Running |
Summary
Read cc-switch MCP entries with the bundled SQLite driver in read-only mode, removing the external
sqlite3requirement.Cause
The importer invoked the
sqlite3executable for schema inspection and row reads, but stock Windows installs do not include it.Blast radius
This changes SQLite-backed cc-switch MCP imports; the legacy JSON fallback remains in place.
Neighbouring behaviours tested
Tests cover the Reasonix-specific enablement column, legacy Codex fallback, empty database handling, and Windows drive-path DSN encoding. The database fixtures now use the bundled driver.
Why this layer
internal/contract/configowns cc-switch config decoding and already depends on the pure-Go SQLite driver through the module.Issues
Fixes #14053
Verification
go test ./internal/contract/config— passed without asqlite3executable installed.go vet ./internal/contract/config— passed.git diff --check— passed.go test ./...— unrelated failures ininternal/state/trustedstateandinternal/state/memory; filesystem-related trustedstate failures reproduce on clean baseline HEAD, and the memory ordering test passes in isolated baseline runs.Disclosure