Repository navigation
fix(mcp): keep add argument errors readable - #14068
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
the
tui
esengine
approved these changes
Oct 21, 2026
esengine
left a comment
esengine
left a comment
Owner
There was a problem hiding this comment.
Checked every place ParseArgs echoes caller input: the unknown-flag and first-argument errors no longer print the value (flag name only), the KEY=VALUE error was already redacted, and the remaining messages carry no input. Dropping the blanket DiagnosticError wrapper is therefore safe, and the help routing matches the other subcommands. Approving; merge after the checks are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
mcp addvalidation errors readable and handlemcp add -h/--helpas help.Cause
ParseArgspassed local syntax errors through dependency error redaction, while the CLI dispatchedaddto parsing before checking its help flag.Blast radius
This affects invalid
mcp addinput and its help flags.Neighbouring behaviours tested
Added coverage for missing arguments, unknown flags without echoing inline values, and the
mcp add --helpexit code/output.Why this layer
The shared MCP argument parser owns syntax errors; the CLI dispatcher owns subcommand help routing.
Issues
Fixes #14052
Verification
go test ./internal/ext/mcpsetup ./internal/frontend/cli— passed.go vet ./internal/ext/mcpsetup ./internal/frontend/cli— passed.git diff --check— passed.go test ./...— twointernal/state/trustedstatefilesystem timestamp/replacement tests also fail on clean baseline HEAD; oneinternal/state/memoryordering test failed in the parallel run but passed in an isolated baseline run.Disclosure