Move LC ++ Tail fusion from v3_core to sys_core_fold#10912
Open
michalmuskala wants to merge 1 commit intoerlang:masterfrom
Open
Move LC ++ Tail fusion from v3_core to sys_core_fold#10912michalmuskala wants to merge 1 commit intoerlang:masterfrom
michalmuskala wants to merge 1 commit intoerlang:masterfrom
Conversation
When `[E || Qs] ++ Tail` is written, the compiler fuses the `++` into
the list comprehension's base case, replacing `[]` with `Tail` to
avoid an O(n) append traversal. Previously this optimization lived in
v3_core and only worked when the LC and `++` appeared in the same
expression. It failed when an intermediate variable separated them:
Expanded = [Exp || Exp <- Exps],
Expanded ++ Tail
Move the optimization to sys_core_fold where it can handle both cases.
After v3_core's `force_safe` binds the letrec to a variable, both the
inline and variable forms produce the same Core Erlang pattern:
let V = letrec lc/1 = ... in apply lc/1(List)
in call erlang:'++'(V, Tail)
The new `opt_lc_append` in `opt_let_2` detects this pattern and
rewrites the LC function to accept an extra tail parameter, replacing
the `[]` base case with the tail argument and eliminating the `++`
call entirely.
Contributor
CT Test Results 2 files 335 suites 9m 19s ⏱️ Results for commit 742ca64. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
Contributor
|
Thanks @michalmuskala - I've hit this before and had to make the frustrating trade-off of code-style vs. performance. |
Contributor
|
Thanks for your pull request. We'll include it in OTP 30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
[E || Qs] ++ Tailis written, the compiler fuses the++into the list comprehension's base case, replacing[]withTailto avoid an O(n) append traversal. Previously this optimization lived in v3_core and only worked when the LC and++appeared in the same expression. It failed when an intermediate variable separated them:Move the optimization to sys_core_fold where it can handle both cases. After v3_core's
force_safebinds the letrec to a variable, both the inline and variable forms produce the same Core Erlang pattern:The new
opt_lc_appendinopt_let_2detects this pattern and rewrites the LC function to accept an extra tail parameter, replacing the[]base case with the tail argument and eliminating the++call entirely.