cache state check - #5844
Merged
Merged
cache state check#5844
Conversation
hexoscott
force-pushed
the
cache-check-rpc
branch
4 times, most recently
from
October 31, 2022 09:37
fa4e176 to
ca9acfd
Compare
hexoscott
force-pushed
the
cache-check-rpc
branch
3 times, most recently
from
November 1, 2022 15:02
948641c to
a760d49
Compare
hexoscott
marked this pull request as ready for review
November 1, 2022 15:10
Contributor
There was a problem hiding this comment.
This does not need to be wrapped into PlainStateReader, instead it can go to the core/rawdb package perhaps? Looking at the user of ReadVersion, it creates PlainStateReader just to call this function
Contributor
There was a problem hiding this comment.
As with the reader function, this does not need to be wrapped into PlainStateWriter, it can be moved to core/rawdb package
AskAlexSharov
approved these changes
Nov 6, 2022
AskAlexSharov
approved these changes
Nov 6, 2022
Contributor
|
I have taken some of these changes to this PR, to update to the latest Erigon-lib: #5973 |
hexoscott
force-pushed
the
cache-check-rpc
branch
from
November 7, 2022 10:39
a760d49 to
4d84d5b
Compare
Contributor
Author
|
Good shout on moving the state version calls into the rawdb, package. Made the changes and re-pushed. |
Contributor
Author
|
This also updates to the latest erigon-lib in the PR, no longer my forked version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft for now to get some early feedback on approach