Repository navigation
docs/site: debug_getModifiedAccountsBy* return null for an empty range - #25937
Open
RyoKusnadi wants to merge 2 commits into
Open
RyoKusnadi wants to merge 2 commits into
RyoKusnadi wants to merge 2 commits into
Conversation
The Returns tables only said 'Array of modified account addresses'. When no account changed in the range the methods return null, same as Geth. Signed-off-by: Ryo Kusnadi <ryokusnadi@gmail.com>
RyoKusnadi
requested review from
AskAlexSharov,
VBulikov and
yperbasis
as code owners
November 8, 2026 15:01
Contributor
|
@RyoKusnadi thanks, the wording looks good. Two small things:
|
…wording Signed-off-by: Ryo Kusnadi <ryokusnadi@gmail.com>
Author
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Returns tables for
debug_getModifiedAccountsByNumberanddebug_getModifiedAccountsByHashonly said "Array of modified account addresses". They didn't say what comes back when no account changed in the range.Problem: someone reading the docs expects
[]for an empty range. The node answersnull.Cause: the methods return a nil slice when nothing changed, which is encoded as
null. Geth'sgetModifiedAccountsdoes the same, and this method isn't in execution-apis, so the node keeps that on purpose.Change: both Returns rows now say "Array of modified account addresses, or
nullif no account changed in the range (same as Geth)", indocs/site/docs/interacting-with-erigon/debug.md. The wording is the one lupin012 suggested. The same two rows are updated inllms-full.txtanddocs/site/static/llms-full.txt, so thegenerate-llms.py --checkstep stays in sync.Scope: only these two methods. No code change. I first tried returning
[]in #25745 and closed it to keep Geth parity.Testing: docs only. The two
llms-full.txtfiles were edited by hand to match the generator's table format (inline code keeps its backticks); I didn't run the docs build orgenerate-llms.py --checklocally, so thedocs-site / buildcheck is the real test. Environment: main @ 7f2df48.Fixes #25649