execution/commitment: remove inert parallel-commitment warmup; refresh design doc - #22042
Merged
Merged
Conversation
…h design doc The EnvWarmupParallelProcess warmup in ParallelPatriciaHashed.Process is never fed any keys (WarmKey runs only on the sequential HashSort path), so it only spawned idle goroutines. Remove it and the dead flag. Refresh docs/design/parallel-patricia-hashed.md for the #21945 deep storage fold.
awskii
requested review from
AskAlexSharov,
bloxster,
mh0lt,
taratorio and
yperbasis
as code owners
June 25, 2026 14:18
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes an unused (“inert”) parallel-commitment warmup path (and its associated env-gated flag), and updates the parallel commitment design doc to reflect the current deep-storage fold behavior introduced in #21945.
Changes:
- Remove
EnvWarmupParallelProcessand the unused Warmuper startup/drain logic fromParallelPatriciaHashed.Process. - Refresh
docs/design/parallel-patricia-hashed.mdto document deep storage folding (mount/unfold/fold model applied at depth 64) and update related invariants/source map.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
execution/commitment/parallel_patricia_hashed.go |
Deletes the env-gated warmup block from the parallel Process path (it was never fed). |
common/dbg/experiments.go |
Removes the dead ERIGON_WARMUP_PARALLEL_PROCESS env experiment flag. |
docs/design/parallel-patricia-hashed.md |
Updates design documentation for the deep storage fold and related invariants/contract details. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
259
to
260
|
|
||
| var warmuper *Warmuper | ||
| if warmup.Enabled && dbg.EnvWarmupParallelProcess { | ||
| if warmup.CtxFactory == nil { | ||
| warmup.CtxFactory = p.trieCtxFactory | ||
| } | ||
| warmuper = NewWarmuper(ctx, warmup) | ||
| warmuper.Start() | ||
| defer warmuper.CloseAndWait() | ||
| } | ||
|
|
||
| rh, mErr := p.processMounted(ctx, updates) |
AskAlexSharov
approved these changes
Jun 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 25, 2026
AskAlexSharov
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnvWarmupParallelProcesswarmup fromParallelPatriciaHashed.Process(never fed —WarmKeyruns only on the sequentialHashSortpath), plus the dead flag.docs/design/parallel-patricia-hashed.mdfor the execution/commitment: parallel deep storage fold via genuine unfold + mount (fixes wrong trie root) #21945 deep storage fold.