cmd/integration: remove domain purification (compact_domains) - #22012
Merged
Merged
Conversation
Domain purification (the compact_domains / purify_domains command) rewrites domain .kv files with repeated keys dropped, so a key live at step X may only exist in an earlier file. That breaks the invariant that a file ending at step X holds the state present at step X, which other tooling relies on — commitment rebuild and 'seg rm-state --latest' (working off the latest state) among them. Removes the command, its helpers (makeCompactableIndexDB, makeCompactDomains), its flags, and the release-instructions step.
AskAlexSharov
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Domain purification — the
compact_domains(aliaspurify_domains) integration command — rewrites domain.kvfiles with repeated keys dropped. A key live at step X may then exist only in an earlier file, so a file ending at step X no longer holds the state present at step X.That invariant breaks tooling that works off the latest on-disk state:
seg rm-state --latest(and working off the resulting state)Change
Removes the command and everything exclusive to it:
compactDomainscobra command + its flags (--out,--replace-in-datadir,--build-idx,--min-skip-ratio[-l0],--from,--to)makeCompactableIndexDB,makeCompactDomainsRELEASE_INSTRUCTIONS.mdstep that ran itread_domains/requestDomainsin the same file are untouched. Thedb/integritycomments about purification stay — already-published files remain purified, so that handling is still needed.Net: -409 lines.
make lintclean;cmd/integrationbuilds + vets.