[SharovBot] fix: eliminate data race in FilesItem.closeFilesAndRemove / Decompressor.Close - #21453
Closed
erigon-copilot[bot] wants to merge 1 commit into
Closed
erigon-copilot[bot] wants to merge 1 commit into
erigon-copilot[bot] wants to merge 1 commit into
Conversation
…sor.Close Two goroutines could concurrently call closeFilesAndRemove on the same FilesItem via the reclamation path, racing on nil-pointer fields and Decompressor internal state. Wrap both closeFilesAndRemove and Decompressor.Close with sync.Once to guarantee at-most-once execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
erigon-copilot
Bot
requested review from
AskAlexSharov and
sudeepdino008
as code owners
May 27, 2026 17:25
Collaborator
|
fixed by #21397 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestHistoryVerification_SimpleBlockscaused by concurrent calls toFilesItem.closeFilesAndRemove()on the same item from multiple goroutines via the reclamation pathFilesItem.closeFilesAndRemove()withsync.Once(closeAndRemovefield) to guarantee the close-and-remove logic executes at most onceDecompressor.Close()withsync.Once(closeOncefield) for defense-in-depth against concurrent close of the same decompressorTest plan
go test -race -count=5 -run TestHistoryVerification_SimpleBlocks ./execution/verify/...passes with no DATA RACEgo build ./...passes🤖 Generated with Claude Code