Skip to content

db/integrity: check txnum lookup misses #21407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AskAlexSharov merged 1 commit into from
May 26, 2026
Merged

db/integrity: check txnum lookup misses #21407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cmd/utils/app/snapshots_cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1919,11 +1919,15 @@ func doCheckRCacheRootAtBlkRange(cliCtx *cli.Context, logger log.Logger) error {
return err
}
defer tx.Rollback()
rcacheTip, _, err := blockReader.TxnumReader().FindBlockNum(ctx, tx, tx.Debug().DomainProgress(kv.RCacheDomain))
rcacheDomainProgress := tx.Debug().DomainProgress(kv.RCacheDomain)
rcacheTip, ok, err := blockReader.TxnumReader().FindBlockNum(ctx, tx, rcacheDomainProgress)
tx.Rollback()
if err != nil {
return err
}
if !ok {
return fmt.Errorf("findBlockNum(%d) not found", rcacheDomainProgress)
}
to = rcacheTip + 1 // exclusive upper bound
logger.Info("[check-rcache-root-at-blk-range] auto-detected --to", "to", to)
}
Expand Down
8 changes: 7 additions & 1 deletion db/integrity/rcache_no_duplicates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,13 @@ func CheckRCacheNoDups(ctx context.Context, sc SamplerCfg, db kv.TemporalRoDB, b

rcacheDomainProgress := tx.Debug().DomainProgress(kv.RCacheDomain)
fromBlock := uint64(1)
toBlock, _, _ := txNumsReader.FindBlockNum(ctx, tx, rcacheDomainProgress)
toBlock, ok, err := txNumsReader.FindBlockNum(ctx, tx, rcacheDomainProgress)
if err != nil {
return fmt.Errorf("findBlockNum(%d) fails: %w", rcacheDomainProgress, err)
}
if !ok {
return fmt.Errorf("findBlockNum(%d) not found", rcacheDomainProgress)
}

if err := ValidateDomainProgress(ctx, db, kv.RCacheDomain, txNumsReader); err != nil {
return err
Expand Down
8 changes: 7 additions & 1 deletion db/integrity/rcache_receipt_root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,13 @@ func CheckReceiptRootIntegrity(ctx context.Context, sc SamplerCfg, db kv.Tempora
defer tx.Rollback()

rcacheDomainProgress := tx.Debug().DomainProgress(kv.RCacheDomain)
rcacheTip, _, _ := txNumsReader.FindBlockNum(ctx, tx, rcacheDomainProgress)
rcacheTip, ok, err := txNumsReader.FindBlockNum(ctx, tx, rcacheDomainProgress)
if err != nil {
return fmt.Errorf("findBlockNum(%d) fails: %w", rcacheDomainProgress, err)
}
if !ok {
return fmt.Errorf("findBlockNum(%d) not found", rcacheDomainProgress)
}

if err := ValidateDomainProgress(ctx, db, kv.RCacheDomain, txNumsReader); err != nil {
return err
Expand Down
8 changes: 7 additions & 1 deletion db/integrity/receipts_no_duplicates.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,13 @@ func CheckReceiptsNoDups(ctx context.Context, sc SamplerCfg, db kv.TemporalRoDB,

receiptProgress := tx.Debug().DomainProgress(kv.ReceiptDomain)
fromBlock := uint64(1)
toBlock, _, _ := txNumsReader.FindBlockNum(ctx, tx, receiptProgress)
toBlock, ok, err := txNumsReader.FindBlockNum(ctx, tx, receiptProgress)
if err != nil {
return fmt.Errorf("findBlockNum(%d) fails: %w", receiptProgress, err)
}
if !ok {
return fmt.Errorf("findBlockNum(%d) not found", receiptProgress)
}

log.Info("[integrity] ReceiptsNoDups starting", "fromBlock", fromBlock, "toBlock", toBlock)
return parallelChunkCheck(ctx, sc.NewSampler(), fromBlock, toBlock, db, blockReader, failFast, string(ReceiptsNoDups), ReceiptsNoDupsRange)
Expand Down
Loading