[SharovBot] Fix BAL divergence between proposer and validator causing glamsterdam block-proposal failure - #20686
Closed
erigon-copilot[bot] wants to merge 1 commit into
Closed
erigon-copilot[bot] wants to merge 1 commit into
erigon-copilot[bot] wants to merge 1 commit into
Conversation
… glamsterdam block-proposal failure
FinalizeTx (serial proposer path) deleted versionedReads for selfdestructed
accounts, but the parallel executor (validator path) did not. When a tx
contained CREATE + SSTORE + SELFDESTRUCT, the proposer's BAL omitted the
storage read while the validator's BAL included it, causing a hash mismatch
and INVALID payload status on ~20-40% of blocks under spamoor traffic.
Fix: remove the `if so.deleted { delete(sdb.versionedReads, addr) }` block
from FinalizeTx. Both paths now retain versionedReads for destroyed accounts,
matching EIP-7928 access-list semantics.
Also improve BAL mismatch diagnostics by logging the full DebugString to
stderr (captured by kurtosis/docker log collection) and revert the
continue-on-error workaround for the glamsterdam CI suite.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Giulio Rebuffo <giulio.rebuffo@gmail.com>
erigon-copilot
Bot
requested review from
AskAlexSharov,
mh0lt,
mriccobene and
yperbasis
as code owners
April 20, 2026 11:01
Member
|
Closing in favour of #20660 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
versionedReadsdeletion inFinalizeTxthat caused BAL hash divergence between serial proposer and parallel validator paths when transactions contained CREATE + SSTORE + SELFDESTRUCT patternscontinue_on_errorworkaround for glamsterdam CI suite now that the root cause is fixedDetails
FinalizeTx(serial proposer path) deletedversionedReadsfor selfdestructed accounts, but the parallel executor (validator path) did not. When a tx contained CREATE + SSTORE + SELFDESTRUCT, the proposer's BAL omitted the storage read while the validator's BAL included it, causing a hash mismatch and INVALID payload status on ~20-40% of blocks under spamoor traffic.Fix: remove the
if so.deleted { delete(sdb.versionedReads, addr) }block fromFinalizeTx. Both paths now retain versionedReads for destroyed accounts, matching EIP-7928 access-list semantics.Test plan
go build ./...passesstability-checkandblock-proposal-checksucceeded*_test.gofiles modified🤖 Generated with Claude Code