Repository navigation
revert: prune: use Put(Current) mdbx's method instead of DelCurrent+Put - #20643
Merged
Merged
Conversation
![erigon-copilot[bot]](https://avatars.githubusercontent.com/in/3015145?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM. If PutCurrent is causing incorrect behavior/regressions in this cursor path, reverting to the explicit DeleteCurrent + Put sequence is the safer choice on release/3.4. The branch conditions still preserve the original optimization: plain Put when the current step prefix differs, and only replace-in-place when the first 8 bytes match the current step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
revert changes introduced in https://github.com/erigontech/erigon/pull/19914/changes
reason: just a moon-shot against "gas missmatch" error