Skip to content

caplin: fix peerdas gossip init order to eliminate false warning - #20538

Merged
AskAlexSharov merged 1 commit into
mainfrom
fix/peerdas-init-order
Apr 14, 2026
Merged

AskAlexSharov merged 1 commit into
mainfrom
fix/peerdas-init-order

Conversation

@domiwei

@domiwei domiwei commented Apr 14, 2026

Copy link
Copy Markdown
Member

Summary

  • Move NewPeerDas() after RegisterGossipServices() so gossip topics are already registered when resubscribeGossip() runs
  • Eliminates the spurious [peerdas] failed to subscribe to column sidecar subnet err="topic not found" warnings on every startup
  • No API changes — pure init reorder; the existing toSubscribes recovery mechanism remains as a safety net

Test plan

  • make erigon builds successfully
  • Start node and verify no more [peerdas] failed to subscribe to column sidecar subnet warnings at startup

🤖 Generated with Claude Code

Move NewPeerDas() after RegisterGossipServices() so that gossip topics
are already registered when resubscribeGossip() runs. This eliminates
the spurious "[peerdas] failed to subscribe to column sidecar subnet
err=topic not found" warnings that appear on every startup.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AskAlexSharov
AskAlexSharov added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit e39ecde Apr 14, 2026
36 checks passed
@AskAlexSharov
AskAlexSharov deleted the fix/peerdas-init-order branch April 14, 2026 09:01
AskAlexSharov added a commit that referenced this pull request Apr 15, 2026
…ng (#20540)

Cherry-pick of #20538

Co-authored-by: kewei-bot <kewei.train@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants