Skip to content

ci: fix hashFiles in composite action output expression - #20153

Merged
yperbasis merged 2 commits into
mainfrom
ci-fix-hashfiles-output
Mar 25, 2026
Merged

yperbasis merged 2 commits into
mainfrom
ci-fix-hashfiles-output

Conversation

@yperbasis

Copy link
Copy Markdown
Member

Summary

  • Use steps.restore.outputs.cache-primary-key instead of re-computing the inline hashFiles expression in the restore-mod-cache composite action's primary-key output. The inline expression was being evaluated at the wrong level (composite action output context rather than step context), causing a cache key mismatch between restore and save.

Cherry-picked from #20146 (ae57f6f) to land independently.

Test plan

  • Verify CI cache hit/miss behavior on a workflow run using this action

🤖 Generated with Claude Code

hashFiles() is not available in composite action outputs.value
expressions. Use steps.restore.outputs.cache-primary-key instead,
which reflects the exact key passed to the cache/restore step.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
awskii
awskii previously approved these changes Mar 25, 2026
@yperbasis
yperbasis disabled auto-merge March 25, 2026 15:00
@awskii
awskii added this pull request to the merge queue Mar 25, 2026
@yperbasis
yperbasis removed this pull request from the merge queue due to a manual request Mar 25, 2026
@yperbasis
yperbasis added this pull request to the merge queue Mar 25, 2026
Merged via the queue into main with commit be8ebb7 Mar 25, 2026
35 checks passed
@yperbasis
yperbasis deleted the ci-fix-hashfiles-output branch March 25, 2026 17:34
wmitsuda pushed a commit that referenced this pull request Apr 1, 2026
## Summary

- Use `steps.restore.outputs.cache-primary-key` instead of re-computing
the inline `hashFiles` expression in the `restore-mod-cache` composite
action's `primary-key` output. The inline expression was being evaluated
at the wrong level (composite action output context rather than step
context), causing a cache key mismatch between restore and save.

Cherry-picked from #20146 (ae57f6f) to land independently.

## Test plan

- [ ] Verify CI cache hit/miss behavior on a workflow run using this
action

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Oleksandr Lystopad <oleksandr.lystopad@erigon.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants