Repository navigation
fix(accessor): reset keyPos/valPos on recsplit collision retry in domain.go - #19752
Merged
AskAlexSharov merged 1 commit intoMar 10, 2026
Merged
AskAlexSharov merged 1 commit into
AskAlexSharov merged 1 commit into
Conversation
…ain.go Same bug pattern as PR #19697 (history.go buildVI page counter). When buildHashMapAccessor encounters a recsplit collision and retries, keyPos and valPos must be reset to 0. Previously they were declared outside the retry loop, causing incorrect offsets in the .kvi index on retry. Also cherry-picks test infrastructure from release/3.4 (PR #19698): - ForceCollisionOnce() method in recsplit for testing - _testBuildVIHook in history.go - TestHistoryBuildVI_PageCounterResetOnCollisionRetry Adds TestDomain_KeyPosResetOnCollisionRetry to verify the fix.
AskAlexSharov
approved these changes
Mar 10, 2026
AskAlexSharov
merged commit Mar 10, 2026
1ebf076
into
cherry-pick-19698-to-main
36 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same bug pattern as PR #19697 (history.go buildVI page counter).
When
buildHashMapAccessorencounters a recsplit collision and retries,keyPosandvalPosmust be reset to 0. Previously they were declared outside the retry loop, causing incorrect offsets in the .kvi index on retry.Changes
keyPosandvalPosdeclarations inside the retry loopTestDomain_KeyPosResetOnCollisionRetryto verify the fixForceCollisionOnce()method in recsplit for testing_testBuildVIHookin history.goTestHistoryBuildVI_PageCounterResetOnCollisionRetryRelated