Repository navigation
cmd/utils/app: delete erigondb.toml.torrent during step-rebase - #19723
Merged
Merged
Conversation
The step-rebase command renames snapshot data files, invalidating existing torrent metadata. While .torrent files in subdirectories (domain/, history/, accessor/, idx/) were already deleted, the erigondb.toml.torrent in the snapshots root was missed.
wmitsuda
enabled auto-merge (squash)
March 7, 2026 22:07
AskAlexSharov
requested review from
anacrolix,
antonis19,
awskii,
bloxster,
canepat,
domiwei,
lupin012,
mh0lt,
mriccobene,
sudeepdino008,
taratorio and
yperbasis
as code owners
March 8, 2026 09:04
AskAlexSharov
approved these changes
Mar 8, 2026
AskAlexSharov
disabled auto-merge
March 8, 2026 09:05
wmitsuda
added a commit
that referenced
this pull request
Mar 8, 2026
## Summary - `erigon seg step-rebase` renames snapshot data files, invalidating existing torrent metadata - `.torrent` files in subdirectories (domain/, history/, accessor/, idx/) were already deleted, but `erigondb.toml.torrent` in the snapshots root was missed - Add it to the deletion list ## Test evidence (hoodi datadir, step 390625 → 78125) **BEFORE rebase** — file exists: ``` -rw-r--r-- 1 wmitsuda wheel 293 Feb 18 22:19 .../snapshots/erigondb.toml.torrent ``` **DURING rebase** — listed for deletion and deleted: ``` D: .../snapshots/erigondb.toml.torrent Deleted: .../snapshots/erigondb.toml.torrent ``` **AFTER rebase** — file is gone: ``` ls: .../snapshots/erigondb.toml.torrent: No such file or directory ``` `erigondb.toml` remains (rewritten with new step size) but `erigondb.toml.torrent` is no longer present. ## Pending - [ ] Cherry-pick the merged commit on main to the branch `release/3.4` after this PR is merged
wmitsuda
added a commit
that referenced
this pull request
Mar 9, 2026
…g step-rebase (#19730) Cherry-pick of #19723 to `release/3.4`. ## Summary - `erigon seg step-rebase` renames snapshot data files, invalidating existing torrent metadata - `.torrent` files in subdirectories (domain/, history/, accessor/, idx/) were already deleted, but `erigondb.toml.torrent` in the snapshots root was missed - Add it to the deletion list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
erigon seg step-rebaserenames snapshot data files, invalidating existing torrent metadata.torrentfiles in subdirectories (domain/, history/, accessor/, idx/) were already deleted, buterigondb.toml.torrentin the snapshots root was missedTest evidence (hoodi datadir, step 390625 → 78125)
BEFORE rebase — file exists:
DURING rebase — listed for deletion and deleted:
AFTER rebase — file is gone:
erigondb.tomlremains (rewritten with new step size) buterigondb.toml.torrentis no longer present.Pending
release/3.4after this PR is merged → [r34] [cherry-pick] cmd/utils/app: delete erigondb.toml.torrent during step-rebase #19730