Conversation
|
Just an idea: we could propose But I do think abstracting away the parsed json Config object, from how/where it's actually called/used further down, is neater. (This only has aesthetic value, if at all) |
|
@somnathb1 Arguably the current version in the EIP (with "cancun", "prague", etc.) is more readable. I don't have the conviction to propose to change it to the "${cancunTime}", etc. But I don't have a strong view on this. |
| BaseFeeUpdateFraction uint64 `json:"baseFeeUpdateFraction"` | ||
| } | ||
|
|
||
| var DefaultCancunBlobConfig = BlobConfig{ |
There was a problem hiding this comment.
I suggest not keeping the default configs anymore
There was a problem hiding this comment.
We need it in some form so that chain.Config returns Ethereum's default blob values when no explicit blobSchedule is provided.
Restores reverted PR #14843 + changes to the following [agreed](https://discord.com/channels/595666850260713488/1360267444911865876) format: ``` { "blobSchedule": { "cancun": { "target": 3, "max": 6, "baseFeeUpdateFraction": 3338477 }, "prague": { "target": 6, "max": 9, "baseFeeUpdateFraction": 5007716 }, "osaka": { "target": 6, "max": 9, "baseFeeUpdateFraction": 5007716 }, "bpo1": { "target": 6, "max": 9, "baseFeeUpdateFraction": 5007716 }, "bpo2": { "target": 12, "max": 18, "baseFeeUpdateFraction": 5007716 }, "bpo3": { "target": 6, "max": 9, "baseFeeUpdateFraction": 5007716 }, "bpo4": { "target": 12, "max": 18, "baseFeeUpdateFraction": 5007716 }, "bpo5": { "target": 6, "max": 9, "baseFeeUpdateFraction": 5007716 } }, "cancunTime": 0, "pragueTime": 0, "osakaTime": 1747387400, "bpo1Time": 1747387400, "bpo2Time": 1747387784, "bpo3Time": 1747388168, "bpo4Time": 1747388552, "bpo5Time": 1747388936 } ``` N.B. Hive EEST tests are [green](https://github.com/erigontech/erigon/actions/runs/15167327678) after 05ca140.
Implement EIP-7892: Blob Parameter Only Hardforks, which is scheduled in Fusaka.
Now
chain.Configmust be copied with jinzhu/copier because I added async.Oncefield (seegetBlobConfig).