Skip to content

Use block's number for heightToDownload when downloading headers #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mininny wants to merge 2 commits into from
Closed

Use block's number for heightToDownload when downloading headers #10094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c51611f
Use block's number for heightToDownload when downloading headers
mininny Apr 27, 2024
b5d24d6
Fix typo
mininny Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion turbo/engineapi/engine_block_downloader/core.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ import (
func (e *EngineBlockDownloader) download(ctx context.Context, hashToDownload libcommon.Hash, requestId int, block *types.Block) {
/* Start download process*/
// First we schedule the headers download process
if !e.scheduleHeadersDownload(requestId, hashToDownload, 0) {
heightToDownload := uint64(0)
if block != nil {
heightToDownload = block.NumberU64()
}
if !e.scheduleHeadersDownload(requestId, hashToDownload, heightToDownload) {
e.logger.Warn("[EngineBlockDownloader] could not begin header download")
// could it be scheduled? if not nevermind.
e.status.Store(headerdownload.Idle)
Expand Down
2 changes: 1 addition & 1 deletion turbo/stages/headerdownload/header_algos.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ func (hd *HeaderDownload) requestMoreHeadersForPOS(currentTime time.Time) (timeo
return
}

hd.logger.Debug("[downloader] Request header", "numer", anchor.blockHeight-1, "length", 192)
hd.logger.Debug("[downloader] Request header", "number", anchor.blockHeight-1, "length", 192)

// Request ancestors
request = &HeaderRequest{
Expand Down