Repository navigation
#8628 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 20 - #8634
Merged
AlexeyGirin merged 2 commits intoNov 21, 2025
Conversation
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor variables to enforce props validation with TypeScript
Convert errorPopover.jsx to TypeScript with proper prop types
Nov 21, 2025
AlexeyGirin
marked this pull request as ready for review
November 21, 2025 08:26
AlexeyGirin
requested review from
rrodionov91
and removed request for
AlexeyGirin,
NataliaLoginova and
Zhirnoff
November 21, 2025 08:27
rrodionov91
approved these changes
Nov 21, 2025
AlexeyGirin
deleted the
copilot/refactor-props-validation-to-typescript-yet-again
branch
November 21, 2025 11:07
AlexeyGirin
added a commit
that referenced
this pull request
Nov 21, 2025
…ite JS to TS) 16 (#8630) * Initial plan * Refactor cliparea.jsx to TypeScript with proper prop type validation Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * fix: Context menu remains visible after creating cyclic structure via right-click menu (#8601) * #7326 - Preview: Delete option is unavailable when right-clicking on a bond in macro mode (#8636) * fix: Delete option is available when right-clicking on a bond in macro mode * test: update snapshots * fix: Selection tool icon open dropdown menu as in Micro mode (#8621) * #8612 Refactor: Prefer tag over ARIA role (part 4) (#8615) * Initial plan * Replace div role="button" with semantic button elements Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Remove redundant aria-disabled attribute in favor of native disabled Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * f1 * f2 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> Co-authored-by: Alexey Girin <agirin@mail.ru> * #8504 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 7 (#8616) * Initial plan * Convert TypeChoice.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Add explanatory comments for type compatibility and required props Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8619 Refactor: Expected a for-of loop instead of a for loop with this simple iteration (part 4) (#8620) * Initial plan * Refactor for loops to for-of loops in utils.js Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8563 Refactor: Mark the props of the component as read-only (#8622) * Initial plan * Mark component props as read-only using Readonly utility type Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8626 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 18 (#8632) * Initial plan * Refactor buttonlist.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Fix parameter naming: rename 'multipl' to 'multiple' in oneOrMore function Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8627 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 19 (#8633) * Initial plan * Convert ComboBox component from JSX to TypeScript with proper prop types Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Address code review feedback - improve type safety and JSX rendering Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8628 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 20 (#8634) * Initial plan * Convert errorPopover.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Initial plan * f1 * f2 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> Co-authored-by: Kristina <kristina_kasyanovskaya@epam.com> Co-authored-by: Alexey Girin <agirin@mail.ru>
KukushkinDmi1riy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…ite JS to TS) 20 (#8634) * Initial plan * Convert errorPopover.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
KukushkinDmi1riy
pushed a commit
that referenced
this pull request
Dec 3, 2025
…ite JS to TS) 16 (#8630) * Initial plan * Refactor cliparea.jsx to TypeScript with proper prop type validation Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * fix: Context menu remains visible after creating cyclic structure via right-click menu (#8601) * #7326 - Preview: Delete option is unavailable when right-clicking on a bond in macro mode (#8636) * fix: Delete option is available when right-clicking on a bond in macro mode * test: update snapshots * fix: Selection tool icon open dropdown menu as in Micro mode (#8621) * #8612 Refactor: Prefer tag over ARIA role (part 4) (#8615) * Initial plan * Replace div role="button" with semantic button elements Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Remove redundant aria-disabled attribute in favor of native disabled Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * f1 * f2 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> Co-authored-by: Alexey Girin <agirin@mail.ru> * #8504 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 7 (#8616) * Initial plan * Convert TypeChoice.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Add explanatory comments for type compatibility and required props Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8619 Refactor: Expected a for-of loop instead of a for loop with this simple iteration (part 4) (#8620) * Initial plan * Refactor for loops to for-of loops in utils.js Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8563 Refactor: Mark the props of the component as read-only (#8622) * Initial plan * Mark component props as read-only using Readonly utility type Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8626 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 18 (#8632) * Initial plan * Refactor buttonlist.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Fix parameter naming: rename 'multipl' to 'multiple' in oneOrMore function Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8627 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 19 (#8633) * Initial plan * Convert ComboBox component from JSX to TypeScript with proper prop types Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Address code review feedback - improve type safety and JSX rendering Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * #8628 Refactor: Variables are missing in props validation (let's rewrite JS to TS) 20 (#8634) * Initial plan * Convert errorPopover.jsx to TypeScript with proper type definitions Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Initial plan * f1 * f2 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> Co-authored-by: Kristina <kristina_kasyanovskaya@epam.com> Co-authored-by: Alexey Girin <agirin@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React components should validate prop types for type safety and maintainability. The errorPopover component was using untyped JavaScript props.
Changes
Added
ErrorPopoverPropsinterface defining all prop types:error: string- error message contentanchorEl: HTMLElement | null- popover anchor elementopen?: boolean- visibility control (defaults totrue)onClose?: () => void- close handler callbackFixed prop naming:
handleClose→onCloseto match actual usage in form.jsxOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.