Repository navigation
#8590 Refactor: Remove all methods from SmilesFormatter class except one - isContainsCoordinates - #8610
Merged
Conversation
…ates Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor SmilesFormatter class to retain only isContainsCoordinates method
Refactor: Remove unused methods from SmilesFormatter class
Nov 20, 2025
Collaborator
|
@copilot remove also all functions that were used in removed methods of |
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Contributor
Author
Removed all unused SMILES serialization code (2,174 lines) in commit 72df6bd:
Build and tests pass successfully. |
Copilot
AI
changed the title
Refactor: Remove unused methods from SmilesFormatter class
Refactor: Remove unused SmilesFormatter methods and SMILES serialization code
Nov 20, 2025
AlexeyGirin
marked this pull request as ready for review
November 20, 2025 18:30
rrodionov91
approved these changes
Nov 20, 2025
AlexeyGirin
added a commit
that referenced
this pull request
Nov 20, 2025
…one - isContainsCoordinates (#8610) * Initial plan * Refactor SmilesFormatter: remove all methods except isContainsCoordinates Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> * Remove unused SmiSerializer and Smiles serialization code Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Removed all instance methods and dependencies from
SmilesFormatterclass, retaining only the static utility methodisContainsCoordinates()which is the sole usage point inserverFormatter.ts.Additionally, removed all unused SMILES serialization code that was only used by the deleted
SmilesFormattermethods, including the entireSmiSerializerclass and related helper modules.Changes Made:
Commit 1: Refactored SmilesFormatter class (45 lines removed)
getStructureFromStructAsync,getStructureFromStringAsyncimplements StructFormatterinterface declarationCommit 2: Removed unused SMILES serialization code (2,174 lines removed)
SmiSerializerclassSmilesclass with all prototype methods:writeAtom(),updateSideBonds(),saveMolecule(),writeCycleNumber(),markCisTrans(),calcBondDirection(),writeRadicals(),isBondInRing()cis_trans.js(219 lines),dfs.js(187 lines),stereocenters.js(729 lines)dfs.test.js,smiles.test.jssmidirectory fromdomain/serializersBefore (64 lines):
After (21 lines):
Impact:
Check list
unit-tests written
e2e-tests written
documentation updated
PR name follows the pattern
#1234 – issue namebranch name doesn't contain '#'
PR is linked with the issue
base branch (master or release/xx) is correct
task status changed to "Code review"
reviewers are notified about the pull request
Fixes Refactor: Remove all methods from
SmilesFormatterclass except one -isContainsCoordinates#8590Original prompt
SmilesFormatterclass except one -isContainsCoordinates#8590✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.