Fix path→base migration gaps in dependency resolution and validation#49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed three bugs where code was reading
dep.pathafter theparsePackageYmlmigration had already moved it todep.basefor local source dependencies.Changes
1. dependency-graph.ts (Bug #1 - HIGH priority)
PackageDependencyinterface to includebasefieldresolveFromManifest()to checkdep.base || dep.path(modern field first, legacy fallback)tests/core/source-resolution/source-resolution.test.tswhere transitive dependencies with local paths were falling through to registry lookup2. dependency-containment.ts (Bug #2 - MEDIUM priority)
dep.basein containment checksdep.path, so dependencies migrated todep.basewere silently skippedbasepath could have been published3. package-management.ts (Bug #3 - LOW priority)
dep.pathtodep.basewhen extracting git source pathsbaseis the subdirectory within the repo (post-migration);pathis for resource selectionsubdirectoryfield for backward compatibilityTest Results
tests/core/source-resolution/source-resolution.test.tsnow passestests/core/add/add-flow-based-mapping.test.tsare unrelatedMigration Context
The
parsePackageYmlfunction performs semantic field migration for local source dependencies:dep.path→dep.base(separates source navigation from resource selection)pathfield, so downstream code must read frombaseThese fixes ensure all three resolution/validation paths handle the migrated field correctly.