fix(patterns): handle copyBag in getRankCover kindMatcher (#3052)#3228
Open
kriskowal wants to merge 1 commit into
Open
fix(patterns): handle copyBag in getRankCover kindMatcher (#3052)#3228kriskowal wants to merge 1 commit into
kriskowal wants to merge 1 commit into
Conversation
|
The match:kind helper's getRankCover only mapped copySet and copyMap to
the 'tagged' pass style, leaving copyBag to fall through to the default
branch where getPassStyleCover('copyBag') threw a TypeError because
'copyBag' is not a known PassStyle. Add copyBag alongside copySet and
copyMap so all three tagged-encoded kinds share the same rank cover.
This was referenced May 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3052
The match:kind helper's getRankCover only mapped copySet and copyMap to the 'tagged' pass style, leaving copyBag to fall through to the default branch where getPassStyleCover('copyBag') threw a TypeError because 'copyBag' is not a known PassStyle. Add copyBag alongside copySet and copyMap so all three tagged-encoded kinds share the same rank cover.