Metadata by rowanG077 · Pull Request #1 · encryption4all/postguard

rowanG077 · 2020-09-21T17:35:58Z

Moved metadata to json.

TODOs:

Make old test pass
Make new tests
Rewrite packages depending on irmaseal-core to use new API.

ivard · 2020-10-28T15:03:32Z

The unit tests work fine, only when I try to compile it as part of irmaseal-cli, I get compile errors. Since irmaseal-cli is included in this repository, this compile error can be fixed within this PR. In Cargo.tom you can set irmaseal-core to { path = "../irmaseal-core" }. Then you'll see the error.

Wassasin · 2020-11-02T13:47:16Z

Do not make irmaseal-core std. When you want to run this in an embedded context (for a secure element) or webassembly having this crate be no-std is essential.

Furthermore I think that having json in a file header is wasteful. There are currently no compact, non-alloc, no-std, serde-compatible serialization crates that have a nice format specification. If you drop the format specification requirement I recommend the postcard crate. I have exhaustively looked into this for other (embedded) projects. If it is a requirement, you could consider paying the postcard author to finish the specification document.

rowanG077 · 2020-11-03T13:35:50Z

@Wassasin I moved to postcard and removed serde_json. Seems to work fine with the unit tests. Still todo is to move the CLI tool and pkg has not been migrated yet.

-- Fixed conditional compilation for stream. -- Fixed irmaseal-pkg with new metadata.

leonbotros

Overall, its looks good. I left some questions though.

leonbotros · 2020-11-20T13:30:15Z

    #[test]
    fn eq_write_read() {
-        let mut buf = IdentityBuf::new();
+        let mut buf: [u8; 1024] = [0; 1024];


We can't use the IdentityBuf type alias here?

leonbotros · 2020-11-20T14:23:51Z

 const IDENTITY_UNSET: u8 = 0xFF;

-// Must be at least 8+1+255+1+254 = 519
+// Must be at least 8+255+1+254 = 518


Why this change? We would still need 1 byte to encode the length of both ArrayStrings?

Not that it matters...

rowanG077 · 2020-12-07T10:38:55Z

@Wassasin Could you quickly look over the changes if everything is Oké with you?

ivard · 2020-12-09T16:07:47Z

        help: Sets the input file to use
        required: true
        index: 1
-    - OUTPUT:


Is it really practical to remove this? If I have a file that is named exactly the same as a file within the tar, what happens then? Is it overwritten then or do I get an error?

rowanG077 requested a review from ivard September 21, 2020 17:35

rowanG077 force-pushed the file-version-metadata branch from d2d8fec to 6bb29b5 Compare September 22, 2020 09:52

ivard reviewed Sep 28, 2020

View reviewed changes

Comment thread irmaseal-core/src/meta.rs Outdated

ivard reviewed Sep 28, 2020

View reviewed changes

Comment thread irmaseal-core/src/meta.rs Outdated

ivard reviewed Sep 28, 2020

View reviewed changes

Comment thread irmaseal-core/src/meta.rs Outdated

rowanG077 changed the title ~~WIP: Metadata~~ Metadata Oct 20, 2020

rowanG077 requested a review from Wassasin November 3, 2020 13:35

rowanG077 force-pushed the file-version-metadata branch from 0775ac8 to e4d93ab Compare November 9, 2020 15:13

rowanG077 force-pushed the master branch from 77d62aa to 9572844 Compare November 9, 2020 15:57

rowanG077 force-pushed the file-version-metadata branch from e4d93ab to 60fad3f Compare November 9, 2020 16:37

rowanG077 added 5 commits November 18, 2020 14:07

WIP: Changed metadata to json representation.

042b323

-- Fixed up unit tests.

fa2f339

-- Fixed conditional compilation for stream. -- Fixed irmaseal-pkg with new metadata.

-- Moved serialization and deserialization to postcard in core.

ff43735

Finished work on tar encryption/decryption.

84e9b3b

Renamed meta to metadata to ensure it works with std enabled.

599a8a6

leonbotros force-pushed the file-version-metadata branch from 5273963 to 599a8a6 Compare November 18, 2020 13:11

leonbotros added 2 commits November 18, 2020 14:17

run rustfmt

3e4c5c7

run rustfmt with 2018 edition

d4f6899

leonbotros reviewed Nov 20, 2020

View reviewed changes

rowanG077 added 2 commits December 7, 2020 11:46

Fixed comments from code review. Mostly small stylistic changes.

3f0c7be

Fix formatting and compile error.

1c63eb6

ivard reviewed Dec 9, 2020

View reviewed changes

Iso5786 force-pushed the file-version-metadata branch from 251d9be to 6ca580a Compare April 15, 2021 09:44

Moved version out of metadata struct, into preamble

20740f3

Iso5786 force-pushed the file-version-metadata branch from 6ca580a to 20740f3 Compare April 15, 2021 11:38

Made PKG compatible with current version

8405df7

Simplified version serialization.

2cb6753

leonbotros removed the request for review from Wassasin April 23, 2021 07:48

leonbotros approved these changes Apr 23, 2021

View reviewed changes

leonbotros merged commit e3807c8 into master Apr 23, 2021

dobby-coder Bot mentioned this pull request Apr 20, 2026

research memory based parts of the pkg #137

Open

dobby-coder Bot mentioned this pull request Jul 5, 2026

fix(pg-pkg): add per-IP rate limiting to /v2 API endpoints (#224) #226

Merged

Uh oh!

Conversation

rowanG077 commented Sep 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ivard commented Oct 28, 2020

Uh oh!

Wassasin commented Nov 2, 2020

Uh oh!

rowanG077 commented Nov 3, 2020

Uh oh!

leonbotros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

leonbotros Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

leonbotros Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

leonbotros Nov 20, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rowanG077 commented Dec 7, 2020

Uh oh!

ivard Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rowanG077 commented Sep 21, 2020 •

edited

Loading