Avoid reopening file on every FileIO read/write#115
Open
flyngmt wants to merge 1 commit intoencounter:mainfrom
Open
Avoid reopening file on every FileIO read/write#115flyngmt wants to merge 1 commit intoencounter:mainfrom
flyngmt wants to merge 1 commit intoencounter:mainfrom
Conversation
Owner
|
Thanks for the PR! It looks like this was explicitly introduced in #77 to avoid locking the file while the game was running. However, I agree that reopening the file on every write is not ideal. Maybe we can keep the file open only while actively writing to it, and close it afterwards. |
Author
|
I didn't realize it was such a new change, lol. Yeah, that's probably the best way then. Current one helps the development but most end users will think game just crashed especially if they are using an HDD. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileIO::fileRead/fileWrite open and close the file on every call, which causes noticeable slowdowns on Card::format().
Takes like a minute on an HDD and 10-15 seconds on an SSD to create the .raw file on the initial run, fixes that by just keeping the file open instead.