Skip to content

fix(bazel): use param file for compile#1373

Merged
walkingeyerobot merged 1 commit into
emscripten-core:mainfrom
zaucy:long-command-line-build-fix
Apr 22, 2024
Merged

fix(bazel): use param file for compile#1373
walkingeyerobot merged 1 commit into
emscripten-core:mainfrom
zaucy:long-command-line-build-fix

Conversation

@zaucy

@zaucy zaucy commented Apr 21, 2024

Copy link
Copy Markdown
Contributor
  • fixes issues on windows when dealing with many dependencies causing a
    'command line too long' error

@zaucy
zaucy force-pushed the long-command-line-build-fix branch from 8e6b45f to a7e4f58 Compare April 21, 2024 22:36
* fixes issues on windows when dealing with many dependencies causing a
  'command line too long' error
@zaucy
zaucy force-pushed the long-command-line-build-fix branch from a7e4f58 to 417ebd7 Compare April 21, 2024 22:37

@walkingeyerobot walkingeyerobot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much!

@walkingeyerobot
walkingeyerobot merged commit ad59642 into emscripten-core:main Apr 22, 2024
@zaucy
zaucy deleted the long-command-line-build-fix branch April 22, 2024 18:30
mmorel-35 pushed a commit to mmorel-35/emsdk that referenced this pull request Feb 3, 2026
* fixes issues on windows when dealing with many dependencies causing a
  'command line too long' error
sbc100 added a commit that referenced this pull request Jun 1, 2026
…and_line (#1715)

I'm not sure why this was originally added as part of #1373, but its
breaking with our transition to using true dynamic linking because bazel
currently does not know how to include PIC versions of the standard
libraries.

See #1714
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants