Update closure-compiler. NFC - #24679
Conversation
kripken
left a comment
There was a problem hiding this comment.
The code diffs look fine, but most of the size changes are small but worse. Maybe worth investigating one to see what changed?
|
I attached the JS generated for the test_minimal_runtime_code_size_hello_embind test. The size differs by just one byte, but if I clang-format the files they don't differ at all. Any idea how to find which is the differing byte here? |
|
Ah, I found an interesting hunk in the code generated by test_codesize_mem_O3_standalone_narg_flto: |
|
Looks like maybe some subtle async/await difference ? |
- return a((await C(c)).instance)
+ return function(d) { return a(d.instance) }(await C(c))Hmm these are identical in every way I think, except that a stack trace would show that nameless thunk function..? Weird closure doesn't remove it, since it does inlining etc. so it is ok with changes to stack traces in principle. |
|
Closing favor of #26869 |
Pull request was closed
No description provided.