Skip to content

Fix missing _emscripten_timeout deps#18909

Merged
sbc100 merged 2 commits into
emscripten-core:mainfrom
rdb:patch-2
Mar 8, 2023
Merged

Fix missing _emscripten_timeout deps#18909
sbc100 merged 2 commits into
emscripten-core:mainfrom
rdb:patch-2

Conversation

@rdb

@rdb rdb commented Mar 7, 2023

Copy link
Copy Markdown
Contributor

This fixes what I believe to be a regression in aef3f83 (#18416) as we have been seeing the following error message:

error: undefined symbol: _emscripten_timeout (referenced by _setitimer_js__deps: ['$timers','$callUserCallback','_emscripten_timeout','emscripten_get_now'], referenced by top-level compiled C/C++ code)
warning: To disable errors for undefined symbols use `-sERROR_ON_UNDEFINED_SYMBOLS=0`
warning: __emscripten_timeout may need to be added to EXPORTED_FUNCTIONS if it arrives from a system library
Error: Aborting compilation due to previous errors

sbc100
sbc100 reviewed Mar 7, 2023
View reviewed changes
Comment thread tools/deps_info.py Outdated
@rdb rdb requested a review from sbc100 March 8, 2023 17:27
@sbc100 sbc100 merged commit c1927f2 into emscripten-core:main Mar 8, 2023
@rdb rdb deleted the patch-2 branch March 8, 2023 17:31
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
@rdb @impact-maker
Fix missing _emscripten_timeout deps (emscripten-core#18909)
398ae9d
impact-maker pushed a commit to impact-maker/emscripten that referenced this pull request Mar 17, 2023
@rdb @impact-maker
Fix missing _emscripten_timeout deps (emscripten-core#18909)
eca6f13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdb @sbc100