This repository was archived by the owner on Jul 16, 2025. It is now read-only.
forked from commaai/openpilot
-
Notifications
You must be signed in to change notification settings - Fork 15
Genesis fix, working #4
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
83bdd27
fix forwarding for giraffe
xx979xx 6da4a9a
fix forwarding for giraffe
xx979xx 1155206
Update carcontroller.py
xx979xx d1511a0
Update interface.py
xx979xx d05c5c1
fix speed error
xx979xx 70cde91
Fix min speed unit
xx979xx c5b7e46
Improve tuning
xx979xx b4206de
tuning
xx979xx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -132,8 +132,8 @@ def update(self, cp): | |
|
|
||
| # There is a 2% error on Sorento GT due to slightly larger wheel diameter compared to poverty packs. | ||
| # Dash assumes about 4% which is excessive. Using 3% to be safe | ||
| if self.car_fingerprint == CAR.SORENTO: | ||
| self.v_wheel = self.v_wheel * 1.03 | ||
| if self.car_fingerprint == CAR.GENESIS: | ||
| self.v_wheel = self.v_wheel * 1.075 | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have you checked this against GPS? |
||
| self.low_speed_lockout = self.v_wheel < 1.0 | ||
|
|
||
| # Kalman filter | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.