Add buffer for pasted stdin and inactive stdin#78
Open
treyhunner wants to merge 1 commit intoemmatyping:mainfrom
Open
Add buffer for pasted stdin and inactive stdin#78treyhunner wants to merge 1 commit intoemmatyping:mainfrom
treyhunner wants to merge 1 commit intoemmatyping:mainfrom
Conversation
Collaborator
|
I merged the browser-ui into CPython repo a while ago. Could you please make a PR against https://github.com/python/cpython/blob/main/Tools/wasm/python.html ? |
Author
|
@tiran I just opened a pull request. 👍 You might want to update the README file here to note that important changes should be made to the cpython repo instead/additionally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me a while to figure out what to hook into, but I believe I finally got standard input working the way I'd expect it to.
Improvements:
I added a separate class because the code started to feel unwieldy after I initially added all the buffering to the existing class. Happy to refactor if desired.
This along with unicode support (there's another PR for that) make this REPL feel pretty much like a native one from my testing (just need to add support for using Ctrl+L to clear the screen). 😁