Repository navigation
ci: run the isolated-install smoke test on the newest Node 22 - #4351
Conversation
Astro 7.4.2 requires Node.js 22.23.4 or later. The isolated-install smoke test installs the newest Astro that the catalog allows, but setup-node used the Node.js 22.23.3 cached on the runner image, so the dev server refused to start. check-latest makes setup-node install the newest Node 22 release from its manifest.
New sites install Astro 7.4.2 or later, which requires Node.js 22.23.4 so that sites run with the October 2026 Node.js security fixes. EmDash's own engines floor stays at 22.16, which still works with Astro 7.3 or earlier.
|
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
There was a problem hiding this comment.
The approach is right and narrowly scoped. The Smoke Isolated Install job copies the starter templates without the lockfile, so it resolves the newest Astro the catalog range allows. Adding check-latest: true to that job's actions/setup-node step makes it use the newest Node 22 release. The other jobs and the minimum-version jobs are unaffected. The four docs pages now consistently say 22.23.4, and the caveat that v22.16.0 is enough on Astro 7.3 or earlier still holds. Both reviewers approved and found nothing that needs fixing. One non-blocking note: existing-project.mdx says Astro 7.4 or later should use 22.23.4, while the new Node floor comes from Astro 7.4.2, so the advice is slightly stricter than needed for 7.4.0 and 7.4.1. Both reviewers did a static review only and did not run CI, so they did not confirm the job now passes.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://noah-silly-moore-54c7d2.try.emdashcms.com, https://noah-silly-moore-54c7d2-emdash-playground.emdash-cms.workers.dev (commit 0d80f8f)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | 0d80f8f | Oct 22 2026, 04:42 PM |
emdashbot
Bot
added
review/needs-review
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
emdashbot
Bot
added
review/needs-review
What does this PR do?
Fixes the "Smoke Isolated Install" job, which fails on every PR that runs it, and updates the Node.js requirement in the docs for new sites.
Astro 7.4.2, released on 2026-10-21, requires Node.js 22.23.4 or later so that sites run with the October 2026 Node.js security fixes. The isolated-install smoke test installs the newest Astro that the catalog's
astro: ^7.3.2allows, butactions/setup-nodewithnode-version: 22uses the Node.js 22.23.3 cached on the runner image. The dev server then exits withNode.js v22.23.3 is not supported by Astro! Please upgrade Node.js to a supported version: ">=22.23.4"(seen on #4350, where the rest of CI passed).test-smoke-isolatedsetup-node step setscheck-latest: true, so it installs the newest Node.js 22 release from the setup-node manifest (22.23.4). The other jobs install Astro 7.3.2 from the lockfile, which runs on the cached Node.js 22, and the jobs that test the minimum version stay on 22.16.0.engines.nodestays>=22.16, and sites on Astro 7.3 or earlier still run on Node.js 22.16.Type of change
Your connection to this change
Checklist
pnpm typecheckpasses (not run: no TypeScript changes)pnpm lintpasses (not run: no JavaScript or TypeScript changes)pnpm testpasses (or targeted tests for my change) (the Smoke Isolated Install job on this PR is the check)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain. (not applicable: no admin UI changes)AI assistance disclosure
Screenshots / test output
Not applicable.
pnpm --dir docs buildpasses.