Repository navigation
Conversation
Below 1024 px the editor's Settings panel is a Kumo sheet that slides in with a 250 ms transform transition. Playwright treats it as visible while it is still moving, and boundingBox() includes the transform, so the 320 px test could read a right edge anywhere between 320 and 640 pixels. CI read 330-619 px. Wait for the sheet's animations to finish before measuring.
|
github-actions
Bot
added
the
query-count changed
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://daniel-content-actions-sheet-settle.try.emdashcms.com, https://daniel-content-actions-sheet-settle-emdash-playground.emdash-cms.workers.dev (commit b437d81)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
github-actions
Bot
added
size/XS
review/needs-review
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
There was a problem hiding this comment.
The approach is sound and narrowly scoped. Below lg the Settings panel is a sheet that slides in, and the test measured it mid-animation. The PR now waits for the sheet's animations to finish before reading boundingBox(), and it leaves the assertions unchanged. This matches the getAnimations() → finished pattern already used elsewhere in the e2e suite. Neither reviewer found a blocking issue. One reviewer left a single optional hardening suggestion, and the other had no findings. The change is test-only, so no changeset is needed. One point is unverified: Kumo's Sidebar source could not be read, so it is not confirmed statically that the transition sits on the element carrying the Settings label. The author's reported before/after runs suggest it does.
Reviewed by anthropic/claude-opus-5-5 and openai/gpt-6.1-sol.
emdashbot
Bot
added
review/needs-review
github-actions
Bot
removed
the
query-count changed
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
docs | b437d81 | Oct 21 2026, 02:17 PM |
What does this PR do?
Stops the 320 px publishing test in
content-actions.spec.tsfrom failing at random in CI. Below 1024 px the editor's Settings panel is a sheet that slides in over 250 ms, and the test measured it while it was still moving, so its right edge could read anywhere between 320 and 640 px. Two recent CI failures, one of them onmain, read 331 to 619 px.The test now waits for the sheet's animations to finish before it measures, and the assertions stay the same. #3285 changed this check after #3249 was reported, but not when it runs.
Closes #3249
Type of change
Your connection to this change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain. (n/a: test-only change)AI assistance disclosure
Screenshots / test output
Test output, Chromium on macOS. When the test shrinks the window, the sheet starts sliding shut, and locally the Settings click lands just as that starts, so the sheet is back almost at once and
mainpasses. A pause before the click stands in for a slower CI runner:mainfails 3 of 3 times with a right edge of 623 px, and this branch passes 5 of 5. With a 120 ms pause, so the click catches the sheet halfway, the branch passes 3 of 3.