Skip to content

ci: reuse pnpm's lockfile supply-chain check across jobs #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danielmlr wants to merge 2 commits into
base: main
Choose a base branch
from
+142 −0
Open

ci: reuse pnpm's lockfile supply-chain check across jobs #4318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90e24b4
ci: reuse pnpm's lockfile supply-chain check across jobs
danielmlr Oct 20, 2026
8bc9f82
ci: key the pnpm lockfile check cache on pnpm-workspace.yaml too
danielmlr Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,17 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
# pnpm skips its supply-chain check of the lockfile when this file holds
# a passing result for the same lockfile content and policy.
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- name: Check package versions
run: node .github/scripts/check-no-major.mjs
- run: pnpm install --frozen-lockfile
Expand Down Expand Up @@ -149,6 +160,15 @@ jobs:
with:
node-version: 22.16.0
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- run: pnpm run --filter emdash... build
- run: pnpm --filter emdash exec vitest run --shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
Expand All @@ -174,6 +194,15 @@ jobs:
with:
node-version: 22.16.0
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- name: Build and test selected packages
if: needs.change-plan.outputs.unit == 'true'
Expand Down Expand Up @@ -296,6 +325,15 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- run: >-
pnpm --filter emdash exec vitest run
Expand All @@ -317,6 +355,15 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- run: >-
pnpm --filter emdash exec vitest run
Expand All @@ -338,6 +385,15 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- if: needs.change-plan.outputs.integration == 'true'
run: pnpm --filter emdash exec vitest run --config vitest.integration.config.ts
Expand All @@ -363,6 +419,15 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- name: Build selected browser suites
if: needs.change-plan.outputs.browser == 'true'
Expand Down Expand Up @@ -436,6 +501,15 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- name: Build Node fixture
id: node-build
Expand Down Expand Up @@ -495,6 +569,15 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- run: pnpm run --filter emdash... build
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/env-types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,19 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
# pnpm skips its supply-chain check of the lockfile when this file holds
# a passing result for the same lockfile content and policy.
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
run: pnpm install --frozen-lockfile
- if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,17 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
# pnpm skips its supply-chain check of the lockfile when this file holds
# a passing result for the same lockfile content and policy.
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- name: Check formatting on main
if: github.event_name == 'push'
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/preview-releases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,17 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
# pnpm skips its supply-chain check of the lockfile when this file holds
# a passing result for the same lockfile content and policy.
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- run: pnpm build
# Publish a preview for every public package via globs rather than a
Expand Down
13 changes: 13 additions & 0 deletions .github/workflows/query-counts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,19 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
# pnpm skips its supply-chain check of the lockfile when this file holds
# a passing result for the same lockfile content and policy.
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- name: Test query normalization
if: github.event_name != 'pull_request' || steps.changes.outputs.relevant == 'true'
run: node --test scripts/query-counts-normalize.test.mjs
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/visual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ jobs:
with:
node-version: 22
cache: pnpm
- name: Prepare pnpm's lockfile check cache
id: pnpm-verdict
run: |
echo "pnpm_config_cache_dir=$HOME/.cache/pnpm" >> "$GITHUB_ENV"
echo "key=pnpm-verdict-$(pnpm --version)" >> "$GITHUB_OUTPUT"
# pnpm skips its supply-chain check of the lockfile when this file holds
# a passing result for the same lockfile content and policy.
- uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
path: ${{ env.pnpm_config_cache_dir }}/lockfile-verified.jsonl
key: ${{ steps.pnpm-verdict.outputs.key }}-${{ hashFiles('pnpm-lock.yaml', 'pnpm-workspace.yaml') }}
- run: pnpm install --frozen-lockfile
- run: pnpm locale:extract
env:
Expand Down
Loading