Repository navigation
Fix(admin): Localize DialogError - #1468
Conversation
🦋 Changeset detectedLatest commit: 4a52a51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
There was a problem hiding this comment.
This is a focused, correct localization fix. The PR localizes the fallback string in getMutationError so it no longer leaks hard-coded English in the admin UI, which is exactly what the linked follow-up (#1244) calls for. The code matches the established pattern in the codebase (i18n._(msg\…`)in utility files) and the globali18n` instance is activated before any call site renders, so there is no risk of an unbound locale. The changeset is well-written and follows the release-notes style in AGENTS.md. No other untranslated instances of this string remain in the admin package. No issues found.
What does this PR do?
This PR is a follow-up on: #1244
It localizes the
DialogErrorhelper function error message to get it covered by Lingui.Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output