Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 5df0a01 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
There was a problem hiding this comment.
This is a focused, correct follow-up PR that wraps three hard-coded English strings in PluginFieldErrorBoundary with Lingui <Trans> so they respect the active admin locale.
Approach: Right change, right place. Localizing user-facing UI strings is exactly what AGENTS.md requires, and using <Trans> from @lingui/react/macro is the standard pattern in the admin package. Because this is a class component, <Trans> in JSX is the idiomatic choice (the useLingui hook is unavailable here).
What I checked:
- The diff is limited to the component and a changeset—no
messages.pochurn, which follows the convention. - The changeset follows AGENTS.md guidance (present-tense verb, describes the observable fix, no internals).
- Import path matches every other usage of
Transinpackages/admin/src. - The
{error?.message || <Trans>…</Trans>}fallback preserves the original||semantics; empty or missing plugin error messages correctly fall back to the localized text. - No directional Tailwind classes are introduced; the component remains RTL-safe.
- No tests exist for this component, and a pure localization change of this scope doesn't strictly require new ones.
The implementation is clean and introduces no regressions.
What does this PR do?
This PR is a follow-up on: #1244
It wraps the
PluginFieldErrorBoundaryheading, fallback message, and retry action with Lingui so they use the active admin locale.For now, the
PluginFieldErrorBoundaryis fully covered for translations. Translators can pickup the changes of theirmessages.poto finish this story.Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output