Repository navigation
i18n(de): add/update German translations - #1161
Conversation
|
|
All contributors have signed the CLA ✍️ ✅ |
Scope checkThis PR changes 2,085 lines across 1 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
This is a solid translation PR that fills in a large number of missing German strings. The informal "du" tone is consistent, and the effort to avoid EN/DE mixing is thoughtful. The author also correctly identified two upstream source-code issues (msgid "Add" and msgid "Edit" used in contexts where German word order breaks the UI, and msgid "{0} permission{1}" which uses English-style suffix pluralization).
However, a handful of permission/scope labels semantically shift "and" to "or", turning cumulative capabilities into alternatives. For example, "Create, update, and delete content" becomes "Erstelle, aktualisiere oder entferne Inhalte". In German, "und" means the user gets all three abilities; "oder" reads as "pick one of these". This is misleading on API-token and marketplace permission screens.
Additionally, one translation drops plural handling and always renders the plural form, producing grammatically incorrect singular text ("1 Berechtigungen").
Finally, @emdash-cms/admin is a published package, so AGENTS.md/CONTRIBUTING.md require a changeset for any user-visible change.
Summary of issues
- 5 semantic mistranslations in permission/scope labels ("and" → "or" or adding "remove" not in source).
- 1 missing plural form that produces incorrect singular grammar.
- 1 missing changeset for the published admin package.
|
Nice auto review - like it. The finding: 1 missing plural form is kinda a false flag. For the missing change set: I checked a few other i18n PRs that got merged and it seems like for plain translation PRs no change set is required. @ascorbic please confirm this. :) This PR is ready for a review. |
…d "Edit" cannot be translated properly
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
|
Will do |
What does this PR do?
My ToDo's prior to requesting a review
Issues found
The
msgid "Add"&msgid "Edit"cannot be translated into German.Additionally, the
msgid "{0} permission{1}"needs to be reworked as it currently does not allow the German plural to be used. I implemented a temporary fix and added a comment to keep track of this.See the pictures at the end of this PR description to better understand the issue
Closes #
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change) - not applicablepnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
Screenshots / test output
Correct would be: "+ Category hinzufügen" or "+ {collectionLabel} hinzufügen"


The issue is that
msgid "Add"&msgid "Edit"are not flexible enough to cover this case. Additionally, they are used at many other places (like editing already existing taxonomies).