Repository navigation
implement upload of latest build of Ember.js, this fixes #644 - #659
Merged
Merged
Conversation
Member
|
@pangratz Thanks. I'll check this out soon. Since this isn't part of Ember core directly, I'm ok if it's a little rough around the edges. We can always clean it up later. |
Member
Author
|
@wagenet ok, great! |
Member
Author
|
There is also an issue regarding the downloads with the used github gem, see piotrmurach/github#21 |
The issue with a failed upload when using the github_api's upload method has been addressed in piotrmurach/github#21
Member
Author
There was a problem hiding this comment.
The nokogiri dependency can be removed as soon as a new version of github_api is released, see piotrmurach/github#23
wagenet
added a commit
that referenced
this pull request
Apr 17, 2012
implement upload of latest build of Ember.js, this fixes #644
sandstrom
pushed a commit
to sandstrom/ember.js
that referenced
this pull request
Jun 17, 2021
…rn/bl-4.0.3 [Security] Bump bl from 4.0.2 to 4.0.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried to code in Ruby and this is the result 😔
It's my try to fix #644. It does work, although I'm sure there is a more Ruby way of coding what I did so please improve my approach.