Skip to content

Command designations of repl and buttercup #384

@jgrey4296

Description

@jgrey4296

eask repl is incorrectly set as eask-special-p, which means eask-setup-paths isn't called.

Meanwhile, eask test buttercup is not marked as an eask-execution-p.
This means the following works fine:

(require 'buttercup)

(describe "error sanity"
  (it "handles user error"
    (expect (user-error "blah") :to-throw))

  (it "handles signal"
    (expect (signal 'error "blah") :to-throw))

However, this will crash the test runner:

(require 'buttercup)

(describe "error failure"
  (it "fails on error"
    (expect (error "%s" "blah") :to-throw)))

Because of the advice added to error and warn.

I'd put this as a pull request, but that seems overkill for such minimal changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions