Repository navigation
fix: Put tensor literal values in the dispatch cache key - #146
Open
georgeguimaraes wants to merge 3 commits into
Open
georgeguimaraes wants to merge 3 commits into
georgeguimaraes wants to merge 3 commits into
Conversation
The dispatch cache keyed a tensor literal by its shape and type only. Two functions that differed only in the values of a literal got the same key, so the second function ran the program of the first and returned wrong results. Now the key also has an md5 of the literal's data. Template tensors have no data and keep the old key.
polvalente
reviewed
Oct 20, 2026
polvalente
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispatch cache keys a tensor literal by its shape and type only. Two functions that differ only in the values of a literal get the same key, so the second function runs the program of the first:
I found this in an ONNX interpreter, where graphs with the same structure have different constant tensors (window functions, resize weights, gather indices). There is no error, only wrong values.
With this change, the key also has an md5 of the literal's data. Template tensors have no data and keep the old key.