feat: support shunt and non PV injection reassignments for jax code#49
Open
BenjPetr wants to merge 4 commits into
Open
feat: support shunt and non PV injection reassignments for jax code#49BenjPetr wants to merge 4 commits into
BenjPetr wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds BSDF test and kernel support for bus-split scenarios where shunts and non-regulating injections are reassigned, and updates tests to be robust to bus ID ordering and dangling-bus handling.
Changes:
- Extend BSDF test helpers to select branches/shunts/injections by string IDs, validate selections, and recompute aggregated bus injections after reassignment.
- Update NumPy + JAX BSDF tests to derive bus reordering from bus IDs and to compare dangling-bus voltages with relaxed tolerances.
- Extend BSDF full-rank update implementations (NumPy + JAX) to include shunt reassignment deltas; expose injection IDs via
StringNetworkInformation.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_helper/bsdf_helper.py | Adds richer BSDF test case definitions (by asset IDs), reassignment helpers, and reference one-step loadflow helpers returning string info. |
| tests/numpy/test_bsdf.py | Uses derived bus ordering + dangling-bus masking/tolerances for reference comparisons. |
| tests/jax/test_bsdf_jax.py | Mirrors NumPy test updates for JAX implementation. |
| src/dc_plus/preprocess/create_network_data.py | Populates StringNetworkInformation.injection_ids from importer data. |
| src/dc_plus/numpy/bsdf_full_rank.py | Refactors full-rank update and adds shunt reassignment contribution support. |
| src/dc_plus/jax/bsdf.py | Adds shunt reassignment contribution support to the dense inverse-transpose updater. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Please check if the PR fulfills these requirements:
Does this PR already have an issue describing the problem?
Fixes #
What is the new behavior (if this is a feature change)?
support shunt and non PV injection reassignments
Does this PR introduce a breaking change?