Repository navigation
Fix the schema diff CI not using faketime for SQLite. - #20099
Merged
Merged
Conversation
Contributor
Schema DiffPlease check that this looks as expected! common (sqlite)Unchanged common (postgres)Unchanged main (sqlite)Unchanged main (postgres)Unchanged state (sqlite)Unchanged state (postgres)Unchanged |
reivilibre
marked this pull request as ready for review
August 13, 2026 13:20
erikjohnston
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue spotted in: #20098
Follows: #20027
We already use
faketimefor Postgres, but I forgot that the SQLite schema delta would have the same problemand somehow tuned it out of the preview diff on the original PR.