Repository navigation
Remove broken DROP statements for SQLite in make_full_schema script. - #20028
Merged
Merged
Conversation
erikjohnston
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken out of #20027 because I'd like to have it land first.
When running
make_full_schema.sh, these drop statements now cause the error:It seems SQLite has cracked down on code that edits the internal tables.
Because SQLite dumps the schema with
CREATE TABLE IF NOT EXISTSfor these virtual tables, it's harmless to leave them in the schema dump.make_full_schema: no longer drop sqlite internal tables