[1vel]

I think 5 years is enough.

Pull Request Checklist

• Pull request is based on the develop branch
• Pull request includes a changelog file. The entry should:
  • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
  • Use markdown where necessary, mostly for code blocks.
  • End with either a period (.) or an exclamation mark (!).
  • Start with a capital letter.
  • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
• Code style is correct (run the linters)

[reivilibre]

Thank you very much, always nice to get a cleanup.

Some archaeology notes:

• Stable version introduced in: https://github.com/matrix-org/synapse/pull/10520 (Synapse v1.50.0, 2022 January)
• Unstable version introduced in: https://github.com/matrix-org/synapse/pull/5727 (Synapse v1.6.0, 2019 November)
• Part of MSC1756

[reivilibre]

Now each entry only produces only one EDU, need to update the 'budgeting' logic on R668 and R691 to compensate.

There are also a bunch of stale comments to remove. :)

[1vel]

I don't see any budgeting logic on R691..

[reivilibre]

sorry for being elusive, I think I meant

            if (
                is_cross_signing_key_update
                and user_id not in cross_signing_keys_by_user
            ):
                # This will give rise to 2 device updates.
                # If we don't have the budget, stop here!
                if remaining_length_budget < 2:
                    break

I think that full block can come out; if we updated this directly we'd change the 2nd if to if remaining_length_budget < 1: BUT we already have assert remaining_length_budget >= 0 earlier, so there is no time it would hit this anymore

[reivilibre]

Thank you!

[1vel]

Perhaps someone else can pick this up later. I don't have enough know-how to fix the test failures.