Skip to content

Register the media threadpool with our metrics #17566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anoadragon453 merged 2 commits into from
Aug 14, 2024
Merged

Register the media threadpool with our metrics #17566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4620d84
Register the media threadpool with our metrics
anoadragon453 Aug 13, 2024
8e93085
re-use changelog from #17564
anoadragon453 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/17566.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Speed up responding to media requests.
4 changes: 4 additions & 0 deletions synapse/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
)
from synapse.http.matrixfederationclient import MatrixFederationHttpClient
from synapse.media.media_repository import MediaRepository
from synapse.metrics import register_threadpool
from synapse.metrics.common_usage_metrics import CommonUsageMetricsManager
from synapse.module_api import ModuleApi
from synapse.module_api.callbacks import ModuleApiCallbacks
Expand Down Expand Up @@ -959,4 +960,7 @@ def get_media_sender_thread_pool(self) -> ThreadPool:
"during", "shutdown", media_threadpool.stop
)

# Register the threadpool with our metrics.
register_threadpool("media", media_threadpool)

return media_threadpool